Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test file for SDoE plot_utils.py #1125

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Add test file for SDoE plot_utils.py #1125

merged 1 commit into from
Mar 28, 2023

Conversation

franflame
Copy link
Contributor

Summary/Motivation:

Added tests for plot_utils.py using mocking for matplotlib.pyplot

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@franflame franflame requested a review from lbianchi-lbl March 23, 2023 00:06
@franflame franflame self-assigned this Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.18 🎉

Comparison is base (5588689) 34.73% compared to head (b2cda54) 34.92%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   34.73%   34.92%   +0.18%     
==========================================
  Files         161      161              
  Lines       36389    36389              
  Branches     5953     5953              
==========================================
+ Hits        12640    12708      +68     
+ Misses      22766    22671      -95     
- Partials      983     1010      +27

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 28, 2023
ksbeattie
ksbeattie approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit b98e42e into CCSI-Toolset:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie ksbeattie approved these changes

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

Assignees

@franflame franflame

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
EY23.4.1.K: Automated test coverage i...
Development

Successfully merging this pull request may close these issues.
3 participants
@franflame @ksbeattie @lbianchi-lbl